Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually execute TTL delete operations #86

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Conversation

zprobst
Copy link
Contributor

@zprobst zprobst commented Sep 6, 2023

We never ported the code that actually performs the TTL. This code includes the deletion operations.

@zprobst zprobst requested a review from ccloes as a code owner September 6, 2023 17:14
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (8d49fc5) 94.29% compared to head (5c39b2b) 94.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   94.29%   94.31%   +0.01%     
==========================================
  Files         121      121              
  Lines        3067     3076       +9     
==========================================
+ Hits         2892     2901       +9     
  Misses        175      175              
Flag Coverage Δ
3.10 94.31% <100.00%> (+0.01%) ⬆️
3.11 94.31% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
nodestream/databases/neo4j/ingest_query_builder.py 100.00% <100.00%> (ø)
nodestream/databases/neo4j/query.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zprobst zprobst merged commit a960d72 into main Sep 7, 2023
4 checks passed
@zprobst zprobst deleted the fix/actually-execute-ttls branch September 7, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants